chore: unstale yarn.lock - #561
Open
Lms24 wants to merge 2 commits into
Open
Conversation
Lms24
requested review from
a team,
cleptric,
mjq and
nsdeschenes
as code owners
August 7, 2026 15:56
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
The pre-release script only needs node_modules to run `yarn generate`, but a plain `yarn install` also re-resolves and rewrites yarn.lock from the release runner's perspective. Yarn 1 records only the optional dependencies it actually resolved for the current platform, so every release commit silently dropped the native binaries for every platform other than the runner's linux-x64 -- 198 package entries in 0.19.0, 154 each in 0.16.0 and 0.13.0. The result was a lockfile that still declared all platform binaries under `optionalDependencies` but had entries for none of them, breaking installs on macOS and Windows while CI stayed green because it also runs on linux-x64. This is the root cause of the periodic "unstale yarn.lock" commits. Refs #561 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure why our lockfile once againgot stale but this unstales it. Came up while reviewing the latest dependabot PRs that made way more changes than appropriate. This PR extracts these changes so that we can keep the dependabot ones minimal.Update: Turns out, our release command installs without a frozen lockfile. so when preparing the release on an Ubuntu VM, we get different dependency entries in the lockfile and commit this back onto
mainafter the release is completed and the release branch is merged onto main. So this PR now also makes our pre-release command use a frozen lockfile which should solve this.