Skip to content

Conversation

@noahsmartin
Copy link
Contributor

@noahsmartin noahsmartin commented Oct 24, 2025

In V9 these protocol conformances are made internal

#skip-changelog

Closes #6523

@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 7.397%. Comparing base (827b50c) to head (e5319d6).
✅ All tests successful. No failed tests found.

❗ There is a different number of reports uploaded between BASE (827b50c) and HEAD (e5319d6). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (827b50c) HEAD (e5319d6)
4 1
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main    #6522        +/-   ##
=============================================
- Coverage   86.492%   7.397%   -79.095%     
=============================================
  Files          451      416        -35     
  Lines        27488    26265      -1223     
  Branches     11970     9670      -2300     
=============================================
- Hits         23775     1943     -21832     
- Misses        3667    24311     +20644     
+ Partials        46       11        -35     
Files with missing lines Coverage Δ
...wift/Integrations/SentryGlobalEventProcessor.swift 0.000% <ø> (-84.616%) ⬇️
...ift/Integrations/UserFeedback/SentryFeedback.swift 0.000% <ø> (-74.419%) ⬇️
...es/Swift/Protocol/Codable/SentryEventDecoder.swift 0.000% <ø> (-100.000%) ⬇️
Sources/Swift/Tools/SentryClientReport.swift 0.000% <ø> (-100.000%) ⬇️
Sources/Swift/Tools/SentryDiscardedEvent.swift 0.000% <ø> (-100.000%) ⬇️

... and 430 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 827b50c...e5319d6. Read the comment docs.

@noahsmartin noahsmartin force-pushed the removeV9SentrySerialize branch from fd8788c to 36079a6 Compare October 24, 2025 01:39
@noahsmartin noahsmartin force-pushed the removeV9SentrySerialize branch from 36079a6 to e5319d6 Compare October 24, 2025 01:48
@github-actions
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1217.57 ms 1247.88 ms 30.31 ms
Size 23.75 KiB 1.00 MiB 1004.60 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
fb611a9 1222.63 ms 1254.79 ms 32.16 ms
3ec47ae 1231.02 ms 1256.67 ms 25.65 ms
7cc23cf 1203.15 ms 1232.11 ms 28.96 ms
2c889f6 1206.35 ms 1233.29 ms 26.94 ms
2be5991 1228.55 ms 1264.65 ms 36.10 ms
354b020 1223.88 ms 1236.82 ms 12.94 ms
9080e6c 1221.17 ms 1247.87 ms 26.71 ms
466e905 1223.78 ms 1256.70 ms 32.92 ms
f8029e2 1245.16 ms 1261.32 ms 16.16 ms
f2bfecd 1234.92 ms 1250.34 ms 15.42 ms

App size

Revision Plain With Sentry Diff
fb611a9 23.74 KiB 1022.38 KiB 998.64 KiB
3ec47ae 23.75 KiB 919.88 KiB 896.13 KiB
7cc23cf 23.75 KiB 913.62 KiB 889.87 KiB
2c889f6 23.75 KiB 1010.42 KiB 986.67 KiB
2be5991 23.75 KiB 994.73 KiB 970.98 KiB
354b020 23.75 KiB 878.19 KiB 854.44 KiB
9080e6c 23.75 KiB 926.80 KiB 903.05 KiB
466e905 23.75 KiB 1010.51 KiB 986.76 KiB
f8029e2 23.75 KiB 893.72 KiB 869.97 KiB
f2bfecd 23.75 KiB 919.68 KiB 895.93 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove V9 checks for SentrySerializable

2 participants