Skip to content

Conversation

@itaybre
Copy link
Contributor

@itaybre itaybre commented Oct 23, 2025

This PR adds a new method in PrivateSentrySDKOnly for SDKs which use our SDK can add a custom view hierarchy.

Fixes: #6491

@github-actions
Copy link
Contributor

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 381272f

@codecov
Copy link

codecov bot commented Oct 23, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
4007 1 4006 52
View the top 1 failed test(s) by shortest run time
iOS_Swift6_UITests.UITests::testLaunchAndCaptureError
Stack Traces | 0s run time
.../iOS-Swift6/iOS-Swift6-UITests/UITests.swift:11 - Failed to get background assertion for target app with pid 10724: Timed out while acquiring background assertion.

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1226.74 ms 1261.31 ms 34.57 ms
Size 23.75 KiB 1.00 MiB 1005.94 KiB

Baseline results on branch: itay/enable_private_only_tests

Startup times

Revision Plain With Sentry Diff
f866f2a 1232.24 ms 1258.84 ms 26.59 ms

App size

Revision Plain With Sentry Diff
f866f2a 23.75 KiB 1.00 MiB 1006.01 KiB

Base automatically changed from itay/enable_private_only_tests to main October 23, 2025 20:53
Copy link
Contributor

@noahsmartin noahsmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it not entirely possible to achieve the same behavior today without adding to this private API? You can call SentrySDK.configureScope { ... } Wouldn't that allow the Godot SDK to do the same thing?

IMO we should try to have fewer hybrid SDK specific APIs, and move towards a version where anything that needs to be visible to an SDK should be part of the public API. So my suggestion is just to double check, do we really need to add an API for this?

@itaybre
Copy link
Contributor Author

itaybre commented Oct 23, 2025

Is it not entirely possible to achieve the same behavior today without adding to this private API? You can call SentrySDK.configureScope { ... } Wouldn't that allow the Godot SDK to do the same thing?

IMO we should try to have fewer hybrid SDK specific APIs, and move towards a version where anything that needs to be visible to an SDK should be part of the public API. So my suggestion is just to double check, do we really need to add an API for this?

The current blocker is SentryAttachment's attachmentType being private only

@noahsmartin
Copy link
Contributor

Makes sense thanks for explaining @itaybre Maybe we should make the attachment type property visible to hybrid SDKs, or visible to everyone? That way the extra logic that would never get called from regular users of the cocoa SDK doesn't have to be included in every native app and can instead be in the Godot repo, seems more scalable/better abstracted that way

@philipphofmann
Copy link
Member

Maybe we should make the attachment type property visible to hybrid SDKs, or visible to everyone?

We didn't decide on this yet, but I think we should come up with proper APIs also for hybrid. This visible only to hybrid only causes problems. We quite often break them. We should treat hybrid as any other SDK user. So IMO we should make the things they need public with a proper API and only change these APIs when doing a major.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose SentryAttachment's attachmentType for Internal SDKs

3 participants