-
-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(profiling): function renames #5007
ref(profiling): function renames #5007
Conversation
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
2fd0f0e | 1225.94 ms | 1247.47 ms | 21.53 ms |
9839a68 | 1228.24 ms | 1247.98 ms | 19.73 ms |
cf7f7c2 | 1215.34 ms | 1239.89 ms | 24.55 ms |
284b1c6 | 1245.83 ms | 1264.37 ms | 18.53 ms |
0a0a2bf | 1213.19 ms | 1239.20 ms | 26.01 ms |
4f73298 | 1211.70 ms | 1234.02 ms | 22.32 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
2fd0f0e | 22.30 KiB | 842.05 KiB | 819.75 KiB |
9839a68 | 22.30 KiB | 843.83 KiB | 821.52 KiB |
cf7f7c2 | 22.30 KiB | 842.86 KiB | 820.56 KiB |
284b1c6 | 22.30 KiB | 843.83 KiB | 821.52 KiB |
0a0a2bf | 22.30 KiB | 843.82 KiB | 821.52 KiB |
4f73298 | 22.30 KiB | 843.23 KiB | 820.92 KiB |
Previous results on branch: armcknight/profiling/new-continuous-apis/8-function-renames
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d974391 | 1241.08 ms | 1258.67 ms | 17.59 ms |
51eb583 | 1236.73 ms | 1255.69 ms | 18.96 ms |
006c78d | 1226.40 ms | 1241.45 ms | 15.05 ms |
82f99cb | 1237.65 ms | 1260.96 ms | 23.31 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d974391 | 22.30 KiB | 843.77 KiB | 821.47 KiB |
51eb583 | 22.30 KiB | 843.09 KiB | 820.79 KiB |
006c78d | 22.30 KiB | 843.78 KiB | 821.48 KiB |
82f99cb | 22.30 KiB | 843.72 KiB | 821.41 KiB |
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## armcknight/git-chain/profiling/new-continuous-apis/6-launch-profiling #5007 +/- ##
=========================================================================================================
Coverage ? 92.743%
=========================================================================================================
Files ? 674
Lines ? 83279
Branches ? 30350
=========================================================================================================
Hits ? 77236
Misses ? 5945
Partials ? 98
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
… around session definition
…w to deal with the deprecated usage in SentryEnabledFeaturesBuilder
5a35e76
to
d1dfcd0
Compare
80190da
to
b6da0a4
Compare
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening an extra PR 💯. LGTM
…unch-profiling' into armcknight/profiling/new-continuous-apis/7-combine-public-methods
…ic-methods' into armcknight/profiling/new-continuous-apis/8-function-renames
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
…unch-profiling' into armcknight/profiling/new-continuous-apis/7-combine-public-methods
…ic-methods' into armcknight/profiling/new-continuous-apis/8-function-renames
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
…unch-profiling' into armcknight/profiling/new-continuous-apis/7-combine-public-methods
…ic-methods' into armcknight/profiling/new-continuous-apis/8-function-renames
…ne-public-methods' into armcknight/profiling/new-continuous-apis/8-function-renames
…unch-profiling' into armcknight/profiling/new-continuous-apis/7-combine-public-methods
…ic-methods' into armcknight/profiling/new-continuous-apis/8-function-renames
…ic-methods' into armcknight/profiling/new-continuous-apis/8-function-renames
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
…unch-profiling' into armcknight/profiling/new-continuous-apis/8-function-renames
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
d21e64c
into
armcknight/git-chain/profiling/new-continuous-apis/6-launch-profiling
I was getting lost trying to debug launch profiling stuff so i renamed some things to try to help bring more clarity. Tried to keep this free of anything but renames, no logic should be changed.
#skip-changelog; for #4853