fix: Limit nested form-data entry keys#6179
Open
elramen wants to merge 10 commits into
Open
Conversation
jjbayer
reviewed
Jul 6, 2026
jjbayer
left a comment
jjbayer
left a comment
Member
There was a problem hiding this comment.
dropping, serializing, and normalizing all still happen recursively
Isn't this true for all user-driven recursive data structures that we have?
Dav1dde
reviewed
Jul 6, 2026
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Dav1dde
approved these changes
Jul 7, 2026
Dav1dde
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Limit nested form-data entry keys to 15. The alternative solution of removing
update_nested_value's recursion does not suffice: dropping, serializing, and normalizing all still happen recursively - we need to limit the depth.Fixes INGEST-992