ref(options): Delegate deserialization to serde instead of generating it per-field#550
Draft
jan-auer wants to merge 1 commit into
Draft
ref(options): Delegate deserialization to serde instead of generating it per-field#550jan-auer wants to merge 1 commit into
jan-auer wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #550 +/- ##
==========================================
+ Coverage 87.41% 87.58% +0.16%
==========================================
Files 92 93 +1
Lines 14695 14819 +124
==========================================
+ Hits 12846 12979 +133
+ Misses 1849 1840 -9
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
SentryOptionsderive macro previously generated adeserializemethod that calledoptions.get()for each struct field individually. This meant the proc macro owned all deserialization logic, including a custom#[sentry_options(rename)]attribute for field renames.Deserialization is now a provided default method on the
SentryOptionstrait: it parses the embedded schema to discover property keys, fetches each value, and delegates toserde_json::from_valuefor the actual struct construction. Options structs must deriveserde::Deserialize, and field renames use standard#[serde(rename)].The derive macro is reduced to emitting only the two constants (
NAMESPACE,SCHEMA) and the singleton/refresh glue.