ref(service): Replace Error with anyhow-like struct with embedded kind#547
Draft
lcian wants to merge 10 commits into
Draft
ref(service): Replace Error with anyhow-like struct with embedded kind#547lcian wants to merge 10 commits into
lcian wants to merge 10 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the
objectstore_service::error::Errorenum (which had a variant per failure source —Io,Reqwest,Serde,BackendResponse,GcpAuth, etc.) with an anyhow-shapedErrorstruct that carries anErrorKindclassification, an optional boxed source error, and an optional context message.This separates error classification from error origin: backends no longer need to choose between increasingly many enum variants, and the API layer maps a flat
ErrorKindto HTTP status codes instead of matching deeply nested enum variants.The new
ErrorKindenum captures the cause of a failure independent of HTTP semantics (ClientStream,InvalidInput,RangeNotSatisfiable,AtCapacity,BackendRateLimited,BackendTimeout,BackendUnavailable,NotImplemented,Internal)Foreign errors convert via
Fromimpls intoErrorKind::Internalwith the original as source; theResultExttrait provides.kind()and.context()to reclassify or annotate withoutmap_errboilerplate.Closes FS-358