Include Plotly.js localization #7323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoshiokatsuneo
force-pushed
the
feat/include_plotly_localization
branch
from
2e1eae5 to
d518a6d
Compare
eradman
reviewed
Feb 18, 2025
I don't think so. |
|
If I'm reading this right, this will add about 88KB to the size of the web app: before after Out of 6.5MB this is an increase of 1.3%, which is probably fine. |
|
I think we determined that this change will have a minimal impact on the size of the distribution. @yoshiokatsuneo please resolve conflicts and I think we can merge. |
yoshiokatsuneo
force-pushed
the
feat/include_plotly_localization
branch
from
d518a6d to
cbd8820
Compare
|
Thanks ! |
|
@eradman Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
For now, the locale for the chat is English. It is not very intuitive for non-english people to show chart in English (ex: "January").
Make localized charts available by including and registering plotly.js localization definitions, and set locale based on browser language.
How is this tested?
I confirmed that the "Month" and pop-up information is localized.