-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Consolidate map headers #6661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Consolidate map headers #6661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzesiek2010
requested changes
Apr 15, 2025
geo/src/main/java/org/odk/collect/geo/geopoint/AccuracyProgressView.kt
Outdated
Show resolved
Hide resolved
geo/src/main/java/org/odk/collect/geo/geopoint/AccuracyStatusView.kt
Outdated
Show resolved
Hide resolved
geo/src/main/java/org/odk/collect/geo/geopoint/AccuracyStatusView.kt
Outdated
Show resolved
Hide resolved
geo/src/main/java/org/odk/collect/geo/geopoint/AccuracyStatusView.kt
Outdated
Show resolved
Hide resolved
grzesiek2010
approved these changes
Apr 25, 2025
Tested with Success! Verified on devices with Androids: 8.1, 10, 14 Verified cases:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6611
This makes the header on geo point/trace/shape maps consistent.
Why is this the best possible solution? Were any other approaches considered?
Introducing a new view let me easily add one way of displaying accuracy without needing to make the same changs in multiple places.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Should just change the styling and text displayed on the geo point/trace/shape headers. Everything should still make sense of course!
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest
(or./gradlew testLab
) and confirmed all checks still passDateFormatsTest