Skip to content

Consolidate map headers #6661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Apr 25, 2025
Merged

Consolidate map headers #6661

merged 20 commits into from
Apr 25, 2025

Conversation

seadowg
Copy link
Member

@seadowg seadowg commented Mar 23, 2025

Closes #6611

This makes the header on geo point/trace/shape maps consistent.

Why is this the best possible solution? Were any other approaches considered?

Introducing a new view let me easily add one way of displaying accuracy without needing to make the same changs in multiple places.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Should just change the styling and text displayed on the geo point/trace/shape headers. Everything should still make sense of course!

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • added any new strings with date formatting to DateFormatsTest
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@seadowg seadowg marked this pull request as ready for review April 2, 2025 13:48
@seadowg seadowg requested a review from grzesiek2010 April 2, 2025 13:48
@seadowg seadowg requested a review from grzesiek2010 April 23, 2025 12:43
@grzesiek2010 grzesiek2010 merged commit a18ebd2 into getodk:master Apr 25, 2025
6 checks passed
@seadowg seadowg deleted the status-text branch April 25, 2025 12:19
@dbemke
Copy link

dbemke commented Apr 30, 2025

Tested with Success!

Verified on devices with Androids: 8.1, 10, 14

Verified cases:

  • map header in all sources of maps in geo widgets wit maps
  • small screen device- Android 8.1
  • landscape and portrait view
  • dark and light mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase font size for map instructions
3 participants