New Area and MenuItem classes #6969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it would be great if |
Comment on lines
161
to
172
| // register all routes from areas | ||
| foreach ($areas as $id => $area) { | ||
| foreach ($areas as $area) { | ||
| $routes = [ | ||
| ...$routes, | ||
| ...static::routesForViews($id, $area), | ||
| ...static::routesForSearches($id, $area), | ||
| ...static::routesForDialogs($id, $area), | ||
| ...static::routesForDrawers($id, $area), | ||
| ...static::routesForDropdowns($id, $area), | ||
| ...static::routesForRequests($id, $area), | ||
| ...static::routesForViews($area), | ||
| ...static::routesForSearches($area), | ||
| ...static::routesForDialogs($area), | ||
| ...static::routesForDrawers($area), | ||
| ...static::routesForDropdowns($area), | ||
| ...static::routesForRequests($area), | ||
| ]; | ||
| } |
There was a problem hiding this comment.
Nitpick: Not necessarily in this PR, but looking at this it just screams to me for
...$area->routes()
|
Looks great! I'd suggest to merge #6970 first in here and then together in the other PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Kirby\Panel\Ui\MenuItemclassKirby\Panel\Areaclass