Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to switch off the Vue template compiler #6958

Closed
wants to merge 11 commits into from

Conversation

bastianallgeier
Copy link
Member

@bastianallgeier bastianallgeier commented Jan 28, 2025

Summary of changes

  • A new vue.runtime.js is added to the dist folder and loaded on demand when the compiler is disabled
  • A new config option (see below) is used in the Assets class to load the right file
  • An info box is shown in lab examples if the compiler is disabled. Lab examples can no longer be displayed
  • A new security warning has been added to the system view when the compiler is active. This might need to be less aggressive.

Todos

Changelog

Enhancements

  • The Vue template compiler can be switched off in the config. This will load the vue runtime version. Plugins and the lab views that rely on the template compiler will no longer work.
// `/site/config/config.php`
return [
  'panel' => [
    'vue' => [
      'compiler' => false
    ]
  ]
]

config/areas/lab/views.php Fixed Show fixed Hide fixed
src/Panel/Assets.php Fixed Show fixed Hide fixed
@bastianallgeier bastianallgeier marked this pull request as draft January 28, 2025 10:52
@bastianallgeier bastianallgeier force-pushed the v5/enhancement/no-template-compiler branch from 3eab5a8 to 92034bc Compare January 30, 2025 13:52
@bastianallgeier
Copy link
Member Author

Closed in favor of #6965

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants