Languages dropdown: fix changing language

getkirby · Jan 24, 2025 · e58bd22 · e58bd22
1 parent 8f83464
commit e58bd22
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/panel/src/components/View/Buttons/LanguagesDropdown.vue b/panel/src/components/View/Buttons/LanguagesDropdown.vue
@@ -10,13 +10,13 @@
 			ref="dropdown"
 			:options="$dropdown(options)"
 			align-x="end"
-			@action="$emit('action', $event)"
 		>
 			<template #item="{ item: language, index }">
 				<k-button
 					:key="'item-' + index"
 					v-bind="language"
 					class="k-dropdown-item k-languages-dropdown-item"
+					@click="change(language)"
 				>
 					{{ language.text }}
 
@@ -73,6 +73,15 @@ export default {
 
 			return null;
 		}
+	},
+	methods: {
+		change(language) {
+			this.$reload({
+				query: {
+					language: language.code
+				}
+			});
+		}
 	}
 };
 </script>

diff --git a/src/Panel/Ui/Buttons/LanguagesDropdown.php b/src/Panel/Ui/Buttons/LanguagesDropdown.php
@@ -67,7 +67,6 @@ public function option(Language $language): array
 		return [
 			'text'    => $language->name(),
 			'code'    => $language->code(),
-			'link'    => $this->model->panel()->url(true) . '?language=' . $language->code(),
 			'current' => $language->code() === $this->kirby->language()?->code(),
 			'default' => $language->isDefault(),
 			'changes' => $changes->exists($language),

diff --git a/tests/Panel/Ui/Buttons/LanguagesDropdownTest.php b/tests/Panel/Ui/Buttons/LanguagesDropdownTest.php
@@ -48,7 +48,6 @@ public function testOption()
 		$this->assertSame([
 			'text'    => 'Deutsch',
 			'code'    => 'de',
-			'link'    => '/pages/test?language=de',
 			'current' => false,
 			'default' => false,
 			'changes' => false,
@@ -81,7 +80,6 @@ public function testOptionsMultiLang()
 			[
 				'text'    => 'English',
 				'code'    => 'en',
-				'link'    => '/pages/test?language=en',
 				'current' => true,
 				'default' => true,
 				'changes' => false,
@@ -91,7 +89,6 @@ public function testOptionsMultiLang()
 			[
 				'text'    => 'Deutsch',
 				'code'    => 'de',
-				'link'    => '/pages/test?language=de',
 				'current' => false,
 				'default' => false,
 				'changes' => false,