Skip to content

fix: veil minor ui changes - #402

Merged
iparaskev merged 3 commits into
mainfrom
fix_veil
Oct 21, 2026
Merged

iparaskev merged 3 commits into
mainfrom
fix_veil

Conversation

@iparaskev

@iparaskev iparaskev commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Closes #398 #401

Summary by CodeRabbit

  • New Features

    • Added a microphone selector to Call audio settings.
    • Added preferred microphone selection with automatic fallback to available devices.
    • Saved microphone preferences now persist across sessions, with clear handling for unavailable devices and save errors.
  • Style

    • Improved panel layout so labels and status information are vertically centered according to their content height.
    • Preserved existing horizontal alignment and sizing.
  • Visual Improvements

    • Increased macOS application icon rendering resolution for clearer, sharper icons.

@netlify

netlify Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for hoppdocs ready!

Name Link
🔨 Latest commit 85cccb7
🔍 Latest deploy log https://app.netlify.com/projects/hoppdocs/deploys/6ad860d43af9611d7b144b99
😎 Deploy Preview https://deploy-preview-402--hoppdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c5dca912-bd7e-498a-ac2c-34fdcb02e3e1
📥 Commits

Reviewing files that changed from the base of the PR and between 7d57e24 and 85cccb7.

📒 Files selected for processing: 5
  • tauri/src-tauri/src/app_state.rs
  • tauri/src-tauri/src/main.rs
  • tauri/src/components/ui/call-center.tsx
  • tauri/src/core_payloads.ts
  • tauri/src/windows/settings/main.tsx

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

📝 Walkthrough

The change adds persisted default microphone selection and resolution through Tauri commands and Call settings. It also centers panel labels by intrinsic height and renders macOS application icons on 64×64 canvases.

Changes: Microphone Preferences

Layer / File(s) Summary
Define and resolve microphone preference
tauri/src-tauri/src/app_state.rs, tauri/src/core_payloads.ts
UserSettings now stores an optional default_mic. Microphone resolution checks the preferred device, last-used device, system default, and first available device. Tests cover migration, fallbacks, persistence, validation, and save failure.
Persist and expose microphone preference
tauri/src-tauri/src/app_state.rs, tauri/src-tauri/src/main.rs
AppState::set_default_mic validates and persists selections. Tauri commands expose setting and resolving the preferred microphone. Call startup uses the shared resolution order.
Configure microphone in settings
tauri/src/windows/settings/main.tsx, tauri/src/components/ui/call-center.tsx
Call settings lists sorted microphone devices and saves selections. Call initialization retrieves the preferred microphone and preserves an existing active selection.

Panel Label Layout

Layer / File(s) Summary
Center label fields
core/src/app_veil/panel.rs
The content view positions both label fields using intrinsic heights and centers them vertically within its bounds.

Application Icon Rendering

Layer / File(s) Summary
Increase icon canvas size
tauri/src-tauri/src/application_catalog.rs
The macOS icon bitmap dimensions and drawing rectangle now measure 64×64 pixels.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Feature

Sequence Diagram(s)

sequenceDiagram
  participant SettingsUI
  participant TauriCommands
  participant AppState
  participant AudioDevices
  SettingsUI->>TauriCommands: set_default_mic(deviceName)
  TauriCommands->>AppState: persist default microphone
  SettingsUI->>TauriCommands: get_preferred_microphone()
  TauriCommands->>AppState: resolve microphone preference
  AppState->>AudioDevices: inspect available devices
  AudioDevices-->>AppState: return device list
  AppState-->>TauriCommands: return resolved microphone
  TauriCommands-->>SettingsUI: return microphone name
Loading
Merge Risk: ⚪ Minimal · up to 85ccc

No actionable merge-blocking issue was established. The change is ready for normal validation and merge.

Pre-merge checks: Passed 3 · Failed 1 · Inconclusive 1

Failed Failed checks: 1 warning · 1 inconclusive

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 57.14% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 21 functions across 7 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check Inconclusive The title refers to UI changes, but it is too vague and does not identify the main change: configurable default microphone selection and settings UI support. Use a specific title such as "feat: add configurable default microphone selection".
Passed Passed checks: 3 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches: 💡 1
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@iparaskev
iparaskev requested a review from konsalex as a code owner October 21, 2026 06:50
@iparaskev
iparaskev merged commit 2390461 into main Oct 21, 2026
24 checks passed
@iparaskev
iparaskev deleted the fix_veil branch October 21, 2026 10:08
kierangraham added a commit to useforesight/hopp that referenced this pull request Nov 3, 2026
Brings in the default microphone setting and app veil fixes (gethopp#402).
Keeps the fork's version 1.1.0 and moves the default microphone
picker into the redesigned settings window.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: set a default microphone in settings

1 participant