feat: add connector unique name suffix #2866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@reneaaron I added tests as suggested and ran the format command. Please have another look. |
Hi @reneaaron could you please check this PR once again? Thanks. |
Awesome, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made in this PR
The accounts in the list of accounts under "Manage accounts" should have unique names. The changes of this PR add a "(1)" suffix to the account name in case an account of the same name already exists. The number in between the brackets "()" is detected and increased by 1, so an account with the same name can be added multiple times and the suffix will be increased from "(1)" to "(2)" to "(3)" etc...
Link this PR to an issue [optional]
Fixes #2793
Type of change
feat: New feature (non-breaking change which adds functionality)Screenshots of the changes [optional]
How has this been tested?
Manually
Checklist