fix: #24 Next.js SDK bad URL defaulting #135
Open
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasballinger
requested changes
Jul 3, 2025
There was a problem hiding this comment.
Unfortunately this doesn't work, in JavaScript passing undefined uses the default value just like not passing the variable!
tomb@macbookpro convex % node
Welcome to Node.js v18.20.6.
Type ".help" for more information.
> function foo(a=1) { return a; }
undefined
> foo(3)
3
> foo()
1
> foo(undefined)
1
I had a version of this in that caused a problem with Convex Auth, we could merge that again if we can confirm the Convex Auth issue is fixed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the issue in #24 , should be a bit less error prone now
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.