Skip to content

Commit 24fa5f4

Browse files
sshaderConvex, Inc.
authored andcommitted
Fix dashboard crons page issue (#36446)
The columns / accessor pattern for the CronsTable is not typesafe so I missed something here. The type returned by `prevNextTs` in `cronDatum` should now match the type `PrevNextTs` (the component) expects. I also did a pass over the other accessors and they all look fine. GitOrigin-RevId: 40e218c40fb6c2f5d2e7db763600d48654ffd5e6
1 parent 8d268f6 commit 24fa5f4

File tree

1 file changed

+4
-4
lines changed
  • npm-packages/dashboard-common/src/features/schedules/components/crons

1 file changed

+4
-4
lines changed

npm-packages/dashboard-common/src/features/schedules/components/crons/CronsTable.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ function Function({ value }: CellProps<CronDatum, string>) {
8282
const url = useFunctionUrl(value);
8383
const name = displayName(value);
8484
return (
85-
<div className="truncate text-content-link hover:underline">
85+
<div className="text-content-link truncate hover:underline">
8686
<Link href={url} legacyBehavior>
8787
{name}
8888
</Link>
@@ -217,7 +217,7 @@ function cronDatum(cronJob: CronJobWithRuns) {
217217
prevDate,
218218
nextDate,
219219
prevRun: lastRun,
220-
state: nextRun.state,
220+
nextRun,
221221
},
222222
udfPath: cronSpec.udfPath,
223223
udfArgs:
@@ -251,15 +251,15 @@ export function CronsTable({ cronJobs }: { cronJobs: CronJobWithRuns[] }) {
251251
});
252252

253253
return (
254-
<Sheet padding={false} className="overflow-x-auto scrollbar">
254+
<Sheet padding={false} className="scrollbar overflow-x-auto">
255255
<div {...getTableProps()} className="mx-4 block min-w-[42rem]">
256256
<div {...getTableBodyProps()} className="divide-y">
257257
{rows.map((row) => {
258258
prepareRow(row);
259259
return (
260260
<div
261261
{...row.getRowProps()}
262-
className="flex items-stretch justify-start gap-2 py-3 text-xs text-content-primary"
262+
className="text-content-primary flex items-stretch justify-start gap-2 py-3 text-xs"
263263
>
264264
{row.cells.map((cell, i) => (
265265
<div

0 commit comments

Comments
 (0)