fix loginFlow flag of cli login (#36445)

The missing behavior was announced in the changelog but not tested, the customer that needed it at the time realized they could use another approach.

GitOrigin-RevId: d47e5bc3a836886d6127bd4388cef2648eb9614c

Author: thomasballinger

npm-packages/convex/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## Unreleased
+
+- The `npx convex login --login-flow paste` flag can be used to explicitly opt
+  into the manual token paste login method.
+
 ## 1.23.0
 
 - `npx convex dev` now supports the option of running Convex locally without an
@@ -29,9 +34,6 @@
 - Calling registered functions directly like helper functions no longer
   typechecks. See release notes for 1.18.0 for more.
 
-- The `npx convex login --auth-flow paste` flag can be used to explicitly opt
-  into the manual token paste login method.
-
 - Upgrade esbuild for a sourcemap bug fix.
 
 - Fix FieldTypeFromFieldPath to handle union of nested values and primitives.

npm-packages/convex/src/cli/lib/login.ts

@@ -286,7 +286,7 @@ export async function performLogin(
     overrideAuthUsername,
     overrideAuthPassword,
     overrideAccessToken,
-    authFlow,
+    loginFlow,
     open,
     acceptOptIns,
     dumpAccessToken,
@@ -298,7 +298,7 @@ export async function performLogin(
     overrideAuthUsername?: string;
     overrideAuthPassword?: string;
     overrideAccessToken?: string;
-    authFlow?: "auto" | "paste" | "poll";
+    loginFlow?: "auto" | "paste" | "poll";
     // default `true`
     open?: boolean;
     // default `false`
@@ -308,7 +308,7 @@ export async function performLogin(
     anonymousId?: string;
   } = {},
 ) {
-  authFlow = authFlow || "auto";
+  loginFlow = loginFlow || "auto";
   // Get access token from big-brain
   // Default the device name to the hostname, but allow the user to change this if the terminal is interactive.
   // On Macs, the `hostname()` may be a weirdly-truncated form of the computer name. Attempt to read the "real" name before falling back to hostname.
@@ -338,7 +338,7 @@ export async function performLogin(
   let auth0;
   let accessToken: string;
 
-  if (authFlow === "paste" || (authFlow === "auto" && isWebContainer())) {
+  if (loginFlow === "paste" || (loginFlow === "auto" && isWebContainer())) {
     accessToken = await promptString(ctx, {
       message:
         "Open https://dashboard.convex.dev/auth, log in and paste the token here:",