feat: integrate Stripe for subscription management and update schema #15
+209
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erquhart
reviewed
Jul 1, 2025
| @@ -19,5 +19,5 @@ jobs: | |||
| cache: "npm" | |||
| - run: npm i | |||
| - run: npm ci | |||
| - run: cd example && npm i && cd .. | |||
| # - run: cd example && npm i && cd .. | |||
There was a problem hiding this comment.
Yes, because the CI completely fails, since there is no "example" directory. I guess in there there should be the generate command maybe?
There was a problem hiding this comment.
Ah right, we have a bunch of examples. Need to fix this.
| @@ -179,6 +179,10 @@ export const convexAdapter = ( | |||
| if (!("runMutation" in ctx)) { | |||
| throw new Error("ctx is not a mutation ctx"); | |||
| } | |||
| if (data.where?.[0] && !data.where?.[0]?.operator) { | |||
| data.where![0].operator = "eq"; | |||
| } | |||
There was a problem hiding this comment.
The adapter should use eq as default, curious if this change is addressing a failure?
There was a problem hiding this comment.
I'll have to check. I think the issue I was facing was because we weren't passing the "where" when getting a user, which would always return the oldest one, instead of the requested one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrated the Stripe plugin beta for better-auth.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.