Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend XTKS hours to 15:30 #433

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Conversation

mzjp2
Copy link

@mzjp2 mzjp2 commented Nov 20, 2024

Workflow to modify an existing Exchange Calendar

  • Modify calendar class as required.
  • Modify the test resources file (e.g tests/resources/{Exchange MIC}.csv), either manually or by executing python etc/make_exchange_calendar_test_csv.py {Exchange MIC}.
  • Check if any of the fixtures in tests/test_{Exchange MIC}_calendar.py need updating to reflect your changes.
  • Add references to any new/modified holidays in exchange_calendars/exchange_calendar_{Exchange MIC}.py.

Closes #432

See:

I see that there is already an open PR to resolve this, but the tests are failing and it hasn't been merged: #429 so I've created this new one that is ready to be merged.

@mzjp2
Copy link
Author

mzjp2 commented Nov 20, 2024

Can I also request that if this is merged, that we release a new version of the package relatively soon after so that everybody has the updated hours for XTKS ASAP given that this change is already live.

@gerrymanoim gerrymanoim merged commit bc23fbe into gerrymanoim:master Nov 22, 2024
7 checks passed
@gerrymanoim
Copy link
Owner

Thanks - will cut a new release when this lands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XTKS (Tokyo Stock Exchange) extends closing hours to 15:30
2 participants