Exclude benchmark data from published package #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit excludes the benchmark data and the benchmark from the published crate. This minimizes the size of the uploaded tar ball by nearly 20% (from 54kb to 41kb). I'm not aware any useful reason to run benchmarks from the published source code, so there shouldn't be any downside in doing that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit excludes the benchmark data and the benchmark from the published crate. This minimizes the size of the uploaded tar ball by nearly 20% (from 54kb to 41kb). I'm not aware any useful reason to run benchmarks from the published source code, so there shouldn't be any downside in doing that.
CHANGES.mdif knowledge of this change could be valuable to users.The reduced size translates to a traffic decrease of 22 GB for crates.io over 90 days using the 1.7 million downloads as listed by crates.io baseline.
This was found while reviewing dependency updates via diff.rs: https://diff.weiznich.de/geographiclib-rs/0.2.4/0.2.5/test_fixtures%2FGeodTest-100.dat
I opted for the
includevariant to make sure only explicitly wanted files are included in the future. See the cargo documentation for more details.