Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

datahubs per sub-portal #8644

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

datahubs per sub-portal #8644

wants to merge 1 commit into from

Conversation

Guillaume-d-o
Copy link

@Guillaume-d-o Guillaume-d-o commented Feb 6, 2025 •
edited
Loading

This is the continuation of the proof-of-concept for the proposal #8021

This work aim to create and manage a datahub in a plugin.
We tried to maximise all the code on the plugin side.

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

@CLAassistant
Copy link

CLAassistant commented Feb 6, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Guillaume-d-o Guillaume-d-o force-pushed the GSIRD-3-temp branch 3 times, most recently from 2fbf024 to 30d9db8 Compare February 17, 2025 15:50
@Guillaume-d-o Guillaume-d-o changed the title Gsird 3 temp datahubs per sub-portal Feb 17, 2025
@Guillaume-d-o Guillaume-d-o marked this pull request as ready for review February 18, 2025 13:43
@Guillaume-d-o Guillaume-d-o marked this pull request as draft February 18, 2025 13:46
@fgravin fgravin requested a review from josegar74 February 18, 2025 14:12
@fgravin
Copy link
Member

fgravin commented Feb 18, 2025

Awesome !! 🤩
Thanks @Guillaume-d-o

@Guillaume-d-o Guillaume-d-o marked this pull request as ready for review February 18, 2025 14:20
@fgravin fgravin requested a review from fxprunayre February 20, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josegar74 josegar74 Awaiting requested review from josegar74

@fxprunayre fxprunayre Awaiting requested review from fxprunayre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Guillaume-d-o @CLAassistant @fgravin