Skip to content

add org.apache.commons.commons-io to Manifest.mf #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from
Open

add org.apache.commons.commons-io to Manifest.mf #305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
eea2995
add org.apache.commons.commons-io to Manifest.mf
poshul Jan 27, 2025
6505db3
bump version to 1.2.0
poshul Jan 27, 2025
f6536db
bump knime version to 5.4
poshul Jan 27, 2025
e437cbe
Update log4j version
poshul Jan 27, 2025
42c4403
Set com.genericworkflownodes.knime.config versions for manifest
poshul Jan 27, 2025
2006dec
revert
poshul Jan 27, 2025
de90e26
Update min knime version reqs
poshul Jan 27, 2025
272efb0
NOP
poshul Jan 27, 2025
d31e77b
revert
poshul Jan 27, 2025
a048d79
fix missing comma
poshul Jan 27, 2025
15752cc
update update site
poshul Jan 27, 2025
f919dfa
try removing "knime.update.site"
poshul Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion com.genericworkflownodes.knime.config.testing/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,5 +66,5 @@
<relativePath>../com.genericworkflownodes.maven</relativePath>
</parent>
<packaging>eclipse-test-plugin</packaging>
<version>1.1.0-SNAPSHOT</version>
<version>1.2.0-SNAPSHOT</version>
</project>
2 changes: 1 addition & 1 deletion com.genericworkflownodes.knime.config/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,5 +30,5 @@
<relativePath>../com.genericworkflownodes.maven</relativePath>
</parent>
<packaging>eclipse-plugin</packaging>
<version>1.1.0-SNAPSHOT</version>
<version>1.2.0-SNAPSHOT</version>
</project>
2 changes: 1 addition & 1 deletion com.genericworkflownodes.knime.feature/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,5 @@
<relativePath>../com.genericworkflownodes.maven</relativePath>
</parent>
<packaging>eclipse-feature</packaging>
<version>1.1.0-SNAPSHOT</version>
<version>1.2.0-SNAPSHOT</version>
</project>
2 changes: 1 addition & 1 deletion com.genericworkflownodes.knime.node_generator/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
<dependency>
<groupId>com.genericworkflownodes.knime.config</groupId>
<artifactId>com.genericworkflownodes.knime.config</artifactId>
<version>1.1.0-SNAPSHOT</version>
<version>1.2.0-SNAPSHOT</version>
<type>eclipse-plugin</type>
</dependency>
</dependencies>
Expand Down
6 changes: 4 additions & 2 deletions ...m/genericworkflownodes/knime/nodegeneration/templates/mavenparent/parent.pom.xml.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,16 @@
<!-- For now we fix the version of the parent pom to 0.0.1 since it has nothing to do with the plugin versions -->
<version>0.0.1-SNAPSHOT</version>
<properties>
<knime.version>4.7</knime.version>
<knime.update.site>http://update.knime.org/analytics-platform/${knime.version}/</knime.update.site>
<knime.version>5.4</knime.version>
<!-- <knime.update.site>http://update.knime.com/analytics-platform/${knime.version}/</knime.update.site> -->
<gkn.update.site>https://abibuilder.cs.uni-tuebingen.de/archive/gkn/updateSite/${knime.version}/</gkn.update.site>
<tycho.version>3.0.1</tycho.version>
<tycho.extras.version>3.0.1</tycho.extras.version>
<tycho.test.jvmArgs>-Xmx1024m</tycho.test.jvmArgs>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
</properties>
<!--
<repositories>
<repository>
<id>knime</id>
Expand All @@ -26,6 +27,7 @@
<url>${gkn.update.site}</url>
</repository>
</repositories>
-->
<build>
<plugins>
<!--
Expand Down
2 changes: 1 addition & 1 deletion com.genericworkflownodes.knime.testing.feature/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,5 @@
<relativePath>../com.genericworkflownodes.maven</relativePath>
</parent>
<packaging>eclipse-feature</packaging>
<version>1.1.0-SNAPSHOT</version>
<version>1.2.0-SNAPSHOT</version>
</project>
2 changes: 1 addition & 1 deletion com.genericworkflownodes.knime.tests/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,5 +61,5 @@
<relativePath>../com.genericworkflownodes.maven</relativePath>
</parent>
<packaging>eclipse-test-plugin</packaging>
<version>1.1.0-SNAPSHOT</version>
<version>1.2.0-SNAPSHOT</version>
</project>
5 changes: 3 additions & 2 deletions com.genericworkflownodes.knime/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,9 @@ Require-Bundle: org.eclipse.ui;bundle-version="[3.107.0,4.0.0)",
org.knime.core.data.uritype;bundle-version="[3.0.0,6.0.0)",
com.genericworkflownodes.knime.config;bundle-version="1.0.0",
org.knime.base.filehandling;bundle-version="[3.1.0,6.0.0)",
org.knime.filehandling.core;bundle-version="4.6.0",
org.apache.log4j;bundle-version="[1.2.21,2.0.0)"
org.knime.filehandling.core;bundle-version="5.4.0",
org.apache.log4j;bundle-version="[2.17.0,3.0.0)",
org.apache.commons.commons-io;bundle-version="[2.15.1,3.0.0)"
Export-Package: com.genericworkflownodes.knime.base.data.port,
com.genericworkflownodes.knime.commandline,
com.genericworkflownodes.knime.commandline.impl,
Expand Down
2 changes: 1 addition & 1 deletion com.genericworkflownodes.knime/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,5 @@
<relativePath>../com.genericworkflownodes.maven</relativePath>
</parent>
<packaging>eclipse-plugin</packaging>
<version>1.1.0-SNAPSHOT</version>
<version>1.2.0-SNAPSHOT</version>
</project>
6 changes: 4 additions & 2 deletions com.genericworkflownodes.maven/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
<artifactId>com.genericworkflownodes.maven</artifactId>
<version>0.0.1-SNAPSHOT</version>
<properties>
<knime.version>4.6</knime.version>
<!-- <knime.version>5.4</knime.version> -->
<java.majorversion>17</java.majorversion>
<knime.update.site>http://update.knime.org/analytics-platform/${knime.version}/</knime.update.site>
<!-- <knime.update.site>http://update.knime.com/analytics-platform/${knime.version}/</knime.update.site> -->
<tycho.version>3.0.1</tycho.version>
<tycho.extras.version>3.0.1</tycho.extras.version>
<tycho.test.jvmArgs>-Xmx1024m</tycho.test.jvmArgs>
Expand All @@ -15,13 +15,15 @@
<tycho.scmUrl>scm:git:https://github.com/genericworkflownodes/GenericKnimeNodes.git</tycho.scmUrl>
<maven-compiler-plugin-version>3.10.1</maven-compiler-plugin-version>
</properties>
<!--
<repositories>
<repository>
<id>knime</id>
<layout>p2</layout>
<url>${knime.update.site}</url>
</repository>
</repositories>
-->
<build>
<plugins>
<!--
Expand Down