Skip to content

Add TMPDIR to PTY spawn modes#1224

Merged
arnestrickmann merged 2 commits intogeneralaction:mainfrom
sairus2k:emdash/debug-obsidian-212
Mar 3, 2026
Merged

Add TMPDIR to PTY spawn modes#1224
arnestrickmann merged 2 commits intogeneralaction:mainfrom
sairus2k:emdash/debug-obsidian-212

Conversation

@sairus2k
Copy link
Contributor

@sairus2k sairus2k commented Mar 2, 2026

Closes #1213

@vercel
Copy link

vercel bot commented Mar 2, 2026

@sairus2k is attempting to deploy a commit to the General Action Team on Vercel.

A member of the Team first needs to authorize it.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Mar 2, 2026

Greptile Summary

Added TMPDIR environment variable to PTY spawn modes to support Nix development environments. The change follows the existing pattern for conditional environment variable passthrough (same as LANG, SSH_AUTH_SOCK).

  • Applied consistently across all three PTY spawn functions: startSshPty(), startDirectPty(), and startPty()
  • Uses the same conditional spread syntax to only include TMPDIR if it exists in the parent process
  • Essential for Nix environments where TMPDIR is used for temporary directories (as seen in flake.nix)

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • The change is minimal (3 identical lines), follows established patterns exactly, and only adds conditional environment variable passthrough. No logic changes or side effects.
  • No files require special attention

Important Files Changed

Filename Overview
src/main/services/ptyManager.ts Added TMPDIR environment variable passthrough to all three PTY spawn modes (startSshPty, startDirectPty, startPty) following the existing pattern for optional environment variables

Last reviewed commit: 2863587

@arnestrickmann
Copy link
Contributor

Thanks for flagging and for opening the PR!

@arnestrickmann
Copy link
Contributor

could you resolve the merge conflicts?
would be amazing, thanks.

@arnestrickmann arnestrickmann merged commit e499644 into generalaction:main Mar 3, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug]: CLI tools that rely on TMPDIR hang silently in Emdash terminals

2 participants