fix: focus agent cli after task creation#1222
Merged
arnestrickmann merged 1 commit intogeneralaction:mainfrom Mar 2, 2026
Merged
Conversation
|
@jschwxrz is attempting to deploy a commit to the General Action Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Greptile SummaryFixed terminal focus issue when creating new tasks by ensuring the auto-focus effect waits for conversations to load before attempting to focus the terminal.
Confidence Score: 5/5
|
| Filename | Overview |
|---|---|
| src/renderer/components/ChatInterface.tsx | Added conversationsLoaded guard to terminal auto-focus effect to prevent focus attempts before TerminalPane renders |
Last reviewed commit: d6b6260
yashdev9274
suggested changes
Mar 2, 2026
Contributor
There was a problem hiding this comment.
hey @jschwxrz i've tested this but focus still goes to chat/agent instead of terminal.
It seems the terminal focus code runs, but something else (may be another useEffect or chat autoFocus) overwrites it afterward.
if you may, please investigate:
- Search for other .focus() calls in ChatInterface.tsx
- Check if chat input has autoFocus that triggers after
- Consider adding terminal focus as the FINAL focus action (after all other effects settle)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary:
fix:
fixes #1221