Add transfer execution status UI #1383
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces TransferExecution, ExecutionState, and ConfirmTransferPresentation types to track and present transfer execution states. Adds TransferStateService and TransferStatePresenter for managing and presenting ongoing and past transfer executions. Integrates a bottom accessory view in MainTabView to display transfer execution status, and updates navigation, view models, and services to support the new flow. Refactors transfer confirmation presentation and error handling, and updates related tests and test kits.
…ability-to-close-confirm-screen-and-show-toast-for-transaction # Conflicts: # Features/Transfer/Sources/ViewModels/ConfirmTransferSceneViewModel.swift
Refactored TransferStateService to make its public methods async for better concurrency handling. Updated usages and tests to accommodate async API. Added comprehensive unit tests for TransferStateService, and fixed ConfirmTransferSceneViewModelTests to use the correct mock data structure.
Updated tabViewBottomAccessoryIfAvailable to accept an isVisible parameter, allowing conditional display of the accessory view. MainTabView now passes visibility based on transferStatePresenter.executions.
…ability-to-close-confirm-screen-and-show-toast-for-transaction # Conflicts: # Gem/Services/ServicesFactory.swift
Added .navigationBarTitleDisplayMode(.inline) to AssetScene to ensure the navigation title is displayed in inline mode for improved UI consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added transfer execution status UI that displays at the bottom of the screen during transaction sending.
Key changes:
TransferStateService(actor) to manage transfer executions across the appTransferStatePresenter(@observable) to expose execution state to UITransferExecutionViewthat shows transfer progressexecuteAsyncmethod for perpetual and swap transactions (iOS 26.0+)Close: #1268
Known issue: https://developer.apple.com/forums/thread/803428?answerId=861715022#861715022
Screenshots
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2025-11-13.at.12.15.31.mov
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2025-11-13.at.12.16.31.mov
TODO