fix(selectivity): dont rely on source maps originalPositionFor mappings#1283
Merged
Conversation
commit: |
✅ Testplane E2E run succeed
|
✅ Testplane browser-env run succeed
|
KuznetsovRoman
commented
Jun 23, 2026
| } | ||
|
|
||
| const dependingSourceFiles = extractSourceFilesDeps( | ||
| const parsedSourceMapRanges = await parseSourceMapRanges( |
Member
Author
There was a problem hiding this comment.
Besides CDP coverage, we only need ranges "from which source file each part of generated file is derived"
| */ | ||
| const offsetToSourceMapLineNumber = (offsetToLine: number[], offset: number): number => { | ||
| let lineNumber = sortedIndex(offsetToLine, offset); | ||
| const getSourceLineOffsetArray = (source: string): number[] => { |
Member
Author
There was a problem hiding this comment.
In result array, arr[i] is "offset to i line"
| let jsonCachedResult: ParsedSourceMapRanges | null = null; | ||
|
|
||
| try { | ||
| const cachedResult = await getCachedSelectivityFile(CacheType.SourceMapParseResult, sourceMaps); |
Member
Author
There was a problem hiding this comment.
Since bundle files can present in multiple tests, caching makes sence
sipayRT
approved these changes
Jun 25, 2026
KuznetsovRoman
force-pushed
the
TESTPLANE-1046.selectivity_alg
branch
from
f49d4cc to
64851e9
Compare
KuznetsovRoman
force-pushed
the
TESTPLANE-1046.selectivity_alg
branch
from
64851e9 to
3a0da09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.