Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify sql method of getting all data requests and build capture access api #46

Merged
merged 3 commits into from
Dec 14, 2021

Conversation

ho-yi-shiuan
Copy link
Collaborator

@ho-yi-shiuan ho-yi-shiuan commented Dec 14, 2021

change sql.execute to sql.query for getting all data requests, also add check if result is black; build api for getting access list for captures

related to #43

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Testing
  • Change that requires a documentation update

How Has This Been Tested?

getting data request: not solved
capture access api: check api by going to /courses/permissions/:courseId

  • Manual Test
  • Unit Test
  • Integration / End-to-End Test

Test Configuration:

Chrome Version 96.0.4664.45 (Official Build) (32-bit)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas that are not self-documenting
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • My changes have no unnecessary logging
  • I have added tests that prove my fix is effective or that my feature works, for sufficiently complex features
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Sensitive info like tokens, secrets, and passwords have been removed before submitting

Modified from this article:
Phillip Johnston, “A GitHub Pull Request Template for Your Projects - Embedded Artistry,” Embedded Artistry, Aug. 04, 2017. https://embeddedartistry.com/blog/2017/08/04/a-github-pull-request-template-for-your-projects/ (accessed Jul. 22, 2021).

@parseccentric
Copy link
Contributor

Known issue: #43

@parseccentric parseccentric merged commit 21aeb50 into master Dec 14, 2021
parseccentric added a commit that referenced this pull request Mar 29, 2022
This reverts commit 21aeb50, reversing
changes made to eb3285d.
parseccentric added a commit that referenced this pull request Mar 30, 2022
This reverts commit 21aeb50, reversing
changes made to 9a8f612.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants