Make all fields of the credentials file optional #51
Conversation
| "tlsCAData": null, | ||
| "tlsSecurity": "strict", | ||
| "tlsServerName": null, | ||
| "user": "edgedb", |
There was a problem hiding this comment.
Shouldn't this be admin? (or do we do some kind of edgedb -> admin conversion based on server version or something?)
There was a problem hiding this comment.
Also the database should not be edgedb no?
There was a problem hiding this comment.
Shouldn't this be admin? (or do we do some kind of edgedb -> admin conversion based on server version or something?)
We currently do the automatic edgedb->admin translation in the server. I'd like to set this to admin when using gel:// but that's not done yet -- all default users are edgedb for now.
Also the database should not be edgedb no?
Unless I missed something, because it is unspecified, it's branch = __default__/database = edgedb.
Effectively the empty credentials file is equivalent to parsing gel://.
There was a problem hiding this comment.
Funny enough we don't have a test for the empty DSN only, but there are some reasonably close tests that resolve the same way as this empty credentials file does.
Specifying a credentials file, even if empty, should be sufficient to ensure a successful connection.
In the case where host or port are missing, the credentials file will contribute the default
localhost:5656.It is no longer an error to specify a credentials file with a missing user.