Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fix to connection_testcases.json #46

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Conversation

diksipav
Copy link
Contributor

No description provided.

@diksipav diksipav requested a review from fmoor January 13, 2025 19:02
@@ -998,7 +998,6 @@
"waitUntilAvailable": "PT30S"
},
"warnings": [
"docker_tcp_port",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is generated now. You have to find this test in the tests/ directory and update it there. Then run ./tools/rebuild.ts to update the connection_testcases.json file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oooh thank u!

@diksipav diksipav merged commit d720f50 into main Jan 13, 2025
1 check passed
@diksipav diksipav deleted the fix-connection-test branch January 13, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants