Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin CLI version #8489

Merged
merged 1 commit into from
Mar 19, 2025
Merged

Pin CLI version #8489

merged 1 commit into from
Mar 19, 2025

Conversation

fantix
Copy link
Member

@fantix fantix commented Mar 19, 2025

geldata/gel-cli#1552 requires a proper fix in the server repo, so pin the CLI to the version before that to unbreak master for now.

@fantix fantix requested review from elprans and mmastrac March 19, 2025 22:39
elprans
elprans approved these changes Mar 19, 2025
View reviewed changes
Copy link
Member

@elprans elprans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, I think we should just get rid of the CLI build in server altogether. gel-python installs a gel entrypoint and downloads a pre-built binary, that's ought to be enough.

@fantix fantix mentioned this pull request Mar 19, 2025
Open
@fantix
Copy link
Member Author

fantix commented Mar 19, 2025

FWIW, I think we should just get rid of the CLI build in server altogether. gel-python installs a gel entrypoint and downloads a pre-built binary, that's ought to be enough.

Sounds good, I'll create a PR.

@fantix fantix merged commit a7dac4b into master Mar 19, 2025
23 checks passed
@fantix fantix deleted the pin-cli branch March 19, 2025 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elprans elprans elprans approved these changes

@mmastrac mmastrac Awaiting requested review from mmastrac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fantix @elprans