Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: VoyageAI integration and embedding models #8443

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

fzowl
Copy link

@fzowl fzowl commented Mar 5, 2025

Adding VoyageAI integration and models.

@gel-data-cla
Copy link

gel-data-cla bot commented Mar 5, 2025

All commit authors signed the Contributor License Agreement.
CLA signed

@fzowl
Copy link
Author

fzowl commented Mar 5, 2025

While i added the integration and i believe it works, i'm not very familiar with EdgeDB - so i'd really appreciate some help on how I can test the integration.

@NikoLandgraf
Copy link

would love this to get merged. Also in need for Voyage Embeddings!

Copy link
Member

@elprans elprans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! This touches a built-in extension, so EDGEDB_CATALOG_VERSION needs bumping in builtmeta.py.

Thanks!

@janwirth
Copy link

Voyage AI have the best performing embeddings right now. I think this is valuable.

@fzowl fzowl requested a review from elprans March 20, 2025 13:37
@fzowl
Copy link
Author

fzowl commented Mar 20, 2025

@elprans Can you please recheck this PR? I corrected the code based on your comments.

Copy link
Member

@elprans elprans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump EDGEDB_CATALOG_VERSION.

@fzowl
Copy link
Author

fzowl commented Mar 23, 2025

@elprans Thank, i raised the EDGEDB_CATALOG_VERSION.

@fzowl fzowl requested a review from elprans March 23, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants