Fix handling of server-initiated messages #158
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #155
Problem
The proxy would fail transferring server-initiated messages (like ping) to end-client as it tried to access properties on an undefined originalRequest, assuming all requests arrived from end-client originally (which is not necessarily true, e.g. the case of server-initiated pings).
Solution
Added an early return in
interceptResponse
(src/lib/utils.ts
) when no matching request exists in pendingRequests, allowing these messages to pass through safely.Testing
Added tests to verify the proxy correctly handles: