Skip to content

create js files for library-preload by default & support json by adding a new option 'format' #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jomaguma
Copy link
Collaborator

@jomaguma jomaguma commented Jun 7, 2018

Support for the new format 'library-preload.js' introduced with UI5 1.40

@geekflyer geekflyer requested a review from cschuff June 11, 2018 10:22
@hhllcks
Copy link

hhllcks commented May 27, 2020

@cschuff could you merge this?

Copy link
Collaborator

@cschuff cschuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jomaguma

I'm sorry but I don't have any capacity to really deeply understand and review this change. Anyways I'm not the one to block it either. Looks good as far as I can tell... Feel free to merge.

BR
Chris

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants