Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to-do-list #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

shivangisahay14
Copy link
Contributor

No description provided.

@suhanichawla suhanichawla requested a review from mansi35 November 1, 2020 12:26
Copy link
Collaborator

@mansi35 mansi35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. You've created a function to clear the to-do list but you've not called it from anywhere. For the function to work, either you have to call it from the HTML or you've to detect an on click event as we have done in all other functions we have written. So try making these changes first.
  2. When you click on the "+" icon it should add the to-do list item to list. Make a function for that too.
  3. When you add a to-do list item the input field should become empty so that new to-do list item can be written. Implement that too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants