Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support emails (update "From" address) #128

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

gabrielcossette
Copy link
Contributor

No description provided.

Copy link
Collaborator

@Moro-Code Moro-Code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it just be set as the email ?
This is what it's set as
EDSC Liste blanche RH - ESDC HR Whitelist [email protected]

also , we should probably look at taking it from the settings rather than hard-coding

@gabrielcossette
Copy link
Contributor Author

Should it just be set as the email ?
This is what it's set as
EDSC Liste blanche RH - ESDC HR Whitelist [email protected]

also , we should probably look at taking it from the settings rather than hard-coding

I added a sender's name to the email address, so that the From doesn't only display the raw email address.

And I agree that we should ideally add it to the Settings, it would be a better place for sure.

@Moro-Code
Copy link
Collaborator

Keeping this as it is now since we have a fix for not being add fields to res.partner which is necessary to add fields in the settings page after the fact. Once that's done, we can flip this PR so that it adds a from field to the settings page

@Moro-Code
Copy link
Collaborator

#134

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants