cleanup updates #206
Merged
cleanup updates #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RulerOf
suggested changes
Feb 2, 2025
There was a problem hiding this comment.
Only issue I see is a possibly unintentional switch from chrome.runtime to chrome.extension in one file, with comments inline on the review.
Embedded jQuery matches sha256sum from the official download url:
╭─ ~
╰─❯ diff <(curl -s "https://code.jquery.com/jquery-1.12.4.min.js" | sha256sum) <(curl -s "https://raw.githubusercontent.com/gboudreau/sabconnectplusplus/5afbec07161a27aabe8c531a08052c631ada2aa8/third_party/jquery/jquery-1.12.4.min.js" | sha256sum)
╭─ ~
╰─❯ echo $?
0
Not an official maintainer, just caught my eye on a Saturday.
- remove unused images/addon_icon.svg - use svg where chrome allows - update to modern sab icon set title to align with extension, bump min chrome to 88 (for v3)
RulerOf
approved these changes
Feb 2, 2025
There was a problem hiding this comment.
Force-push fixed my call-out. Embedded jQuery still matches:
╭─ ~
╰─❯ diff <(curl -s "https://code.jquery.com/jquery-1.12.4.min.js" | sha256sum) <(curl -s "https://raw.githubusercontent.com/gboudreau/sabconnectplusplus/4765eb3cb25b98f0aaa01166d478482e5e88f117/third_party/jquery/jquery-1.12.4.min.js" | sha256sum)
╭─ ~
╰─❯ echo $?
0
LGTM.
gboudreau
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cleanup image usage
set title to align with extension
bump min chrome to 88
bump jquery 1.9.1 -> 1.12.4