Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding source and sourceId filter to existing api #566

Merged
merged 10 commits into from
Apr 24, 2024
Merged

adding source and sourceId filter to existing api #566

merged 10 commits into from
Apr 24, 2024

Conversation

ahakanzn
Copy link
Contributor

@ahakanzn ahakanzn requested a review from marcos-lg April 22, 2024 11:46
@marcos-lg
Copy link
Contributor

I think you forgot to update the gbif-api version to use the changes that you did in the gbif-api project? otherwise this branch doesn't compile

@marcos-lg
Copy link
Contributor

Also, the query parameters are not being set to the request so they don't reach the service. You have to add the parsing to the argument resolvers(InstitutionSearchRequestHandlerMethodArgumentResolver and CollectionSearchRequestHandlerMethodArgumentResolver)

@marcos-lg
Copy link
Contributor

I suggest adding tests. For the persistence layer you can add tests to InstitutionMapperIT and CollectionMapperIT, for the service layer to InstitutionServiceIT and CollectionServiceIT and for the resource layer to InstitutionResourceIT and CollectionResourceIT

@marcos-lg marcos-lg merged commit 20fe72d into dev Apr 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcos-lg marcos-lg marcos-lg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahakanzn @marcos-lg @muttcg