Gadm search

[fmendezh]

This PR supports the functionality described in issue #8

[marcos-lg]

I didn't check the queries. The rest seems ok. The formatting seems random in some places though.

[tucotuco]

Yes, please. :-)

…

On Wed, Sep 16, 2020 at 12:03 PM Matt Blissett ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In geocode-api/src/main/java/org/gbif/geocode/api/service/GadmService.java <#13 (comment)>: > +import javax.annotation.Nullable; +import javax.validation.constraints.Max; +import javax.validation.constraints.Min; + +public interface GadmService { + + Collection<GadmRegion> ***@***.*** String query); + + Collection<GadmRegion> ***@***.*** String query, String gid0); + + Collection<GadmRegion> ***@***.*** String query, String gid0, String gid1); + + Collection<GadmRegion> ***@***.*** String query, String gid0, String gid1, String gid2); + + PagingResponse<GadmRegion> ***@***.*** String query, + @max(value = 2, message = "Only levels 0, 1 and 2 are supported") Shouldn't level 3 be supported? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#13 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADQ723VDAR7CXVEPKUJXJLSGDHTXANCNFSM4Q6JIOQQ> .

[fmendezh]

I didn't check the queries. The rest seems ok. The formatting seems random in some places though.
I agree the format is odd everywhere but I prefer to do commit fixing the entire format for this project later