Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing literature filters #943

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

danielvdm2000
Copy link
Contributor

The issue description was a bit vague, so i just wanna make sure everything looks good.

Issue: #923

Let me know what you think :)

@MortenHofft
Copy link
Member

MortenHofft commented Feb 12, 2025

I think it looks good. But have 2 comments

  1. The filterNames translations. Are they used anywhere?
    If a few of them are in use I'd rather add them to our existing file with filter names. The majority seem to come from the resourceSearch file anyhow.

  2. I would like to see some more help texts though. As a minimum the existing one for scientific name: Note: Applying this filter will exclude papers not explicitly focused on (a) specific taxon/taxa

We can add features and help text later, but I'd prefer if we didn't upload unnecessary files for translation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants