Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow WithPath to work for floating point numbers #450

Merged
merged 1 commit into from
Mar 2, 2025

Conversation

alvii147
Copy link
Contributor

@alvii147 alvii147 commented Oct 5, 2024

#449 details the problem. The fix was to handle the cases of float32 and float64 separately, and use strconv.FormatFloat instead of fmt.Sprint in those cases.

I've also added a couple of test cases to verify it works and doesn't break this for other types.

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 94.815% (+0.002%) from 94.813%
when pulling db112b3 on alvii147:alvii147/449/WithPath-floating-point
into 07a4dbe on gavv:master.

@gavv gavv added the ready for review Pull request can be reviewed label Oct 7, 2024
@gavv
Copy link
Owner

gavv commented Mar 2, 2025

Makes sense. Thanks!

@gavv gavv merged commit ffe5602 into gavv:master Mar 2, 2025
13 checks passed
@gavv gavv removed the ready for review Pull request can be reviewed label Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants