Rework user commands to add to container commands #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kergoth
previously approved these changes
Sep 22, 2020
|
Thanks! |
matthoosier-garmin
previously approved these changes
Sep 29, 2020
pyrex.py
Outdated
| with open(shim, "w") as f: | ||
| f.write( | ||
| textwrap.dedent( | ||
| """\ |
There was a problem hiding this comment.
Nit: this seems weird. Why is the opening line here indented even further than the others? I don't think the function requires that.
There was a problem hiding this comment.
It doesn't. black indents the """ line but leaves the rest so sometimes the indentation gets off when I refactor things.
Adds test to validate that the TTY is correctly passed through to the container when stdout is a TTY
Defaults to 20.04 since that is the most recent sanity tested Ubuntu version
JoshuaWatt
dismissed stale reviews from matthoosier-garmin and kergoth
via
0601b81
|
OOps. I didn't realize this PR was tied to my master branch. Moved to PR #60 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks the way that commands specified by the user are wrapped by
Pyrex. Instead of completely replacing the container commands, the user
commands override and extend the container command defintions, taking
precedence over them (i.e. if the user excludes a command it will be
excluded even if the container includes it, and if the user includes it,
it will be included even if the container excludes it).
In order for this to work, the user command shims must be individually
written to execute the full path to the command inside the container,
since we don't know if it will be in $PATH.