Refactored the NOOP client into a separate package#504
Merged
gardener-prow[bot] merged 2 commits intoMay 21, 2026
Merged
Conversation
Signed-off-by: Ilia Petrov <ilia.yavorov.petrov@gmail.com>
…crete implemntation, not an interface Signed-off-by: Ilia Petrov <ilia.yavorov.petrov@gmail.com>
gardener-prow
Bot
added
kind/cleanup
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobi-Wan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. DetailsGit tree hash: 69c2ca295f99e766430c37c00f8406cb6ea648ab |
gardener-prow
Bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/kind cleanup
/area logging
What this PR does / why we need it:
Refactored the NOOP client into a separate package + updated the New function to return a concrete struct instead of an interface, following the recommendation from
100 Go Mistakes (Chapter 7: “Returning interfaces”).Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: