Fixed a bug reported on Nov 12, 2021.

Fixed a bug reported on Nov 12, 2021 (MPQS running out of polynomials for some number) -- use CFRAC instead if that happens.
gap-packages · Apr 7, 2024 · d5a4a4a · d5a4a4a
1 parent ade686d
commit d5a4a4a
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/lib/mpqs.gi b/lib/mpqs.gi
@@ -247,7 +247,15 @@ BindGlobal("MPQSSplit", function (n)
       if PolyCount > 0 then
         i := NraFactors;
         while   aFactorsSelectedPositions[i] 
-              = aFactorsPoolsize - (NraFactors - i) do i := i - 1; od;
+              = aFactorsPoolsize - (NraFactors - i)
+        do
+          i := i - 1;
+          if i = 0 then
+            Info(IntegerFactorizationInfo,2,
+                 "The MPQS ran out of polynomials, using CFRAC instead.");
+            return CFRACSplit(n/Multiplier);
+          fi; 
+        od;
         aFactorsSelectedPositions[i] := aFactorsSelectedPositions[i] + 1;
         for j in [i + 1..NraFactors] do
           aFactorsSelectedPositions[j] := 
@@ -552,4 +560,4 @@ end);
 
 #############################################################################
 ##
-#E  mpqs.gi  . . . . . . . . . . . . . . . . . . . . . . . . . . .  ends here
+#E  mpqs.gi  . . . . . . . . . . . . . . . . . . . . . . . . . . .  ends here