Skip to content

fix: avoid rendering the design library modal again #3699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Arukuen wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: avoid rendering the design library modal again #3699

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/plugins/guided-modal-tour/editor-block-tour.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,13 @@ import { registerPlugin } from '@wordpress/plugins'
import { useEffect, useState } from '@wordpress/element'
import { GuidedModalTour } from '~stackable/components'

// These tours render inside their own modal.
// Rendering the tours here creates duplicate tour modals and
// can close the owning modal unexpectedly.
const MODAL_OWNED_TOURS = [
'design-library',
]

const EditorBlockTour = () => {
const [ tourId, setTourId ] = useState( 'blocks' )
useEffect( () => {
Expand All @@ -16,7 +23,7 @@ const EditorBlockTour = () => {
}, [] )

// Do not load if there is no tourId.
if ( ! tourId ) {
if ( ! tourId || MODAL_OWNED_TOURS.includes( tourId ) ) {
return null
}

Expand Down
Loading