Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change cutadapt version to 4.9 in section Processing multiple datasets #5741

Conversation

VerenaMoo
Copy link
Contributor

@VerenaMoo VerenaMoo commented Feb 11, 2025

In the tutorial for Quality Control in the section "Trim and filter - short reads" the version of Cutadapt was already changed to 4.9 but not in the section "Processing multiple datasets". Therefore I changed the Cutadapt version to 4.9 in this section as well.

@VerenaMoo VerenaMoo requested a review from a team as a code owner February 11, 2025 12:28
bgruening
bgruening previously approved these changes Feb 11, 2025
Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks a lot!

> - *"Quality cutoff(s) (R1)"*: `20`
> - In *"Read Filtering Options"*
> - *"Minimum length (R1)"*: `20`
> - {%icon param-select%} *"Outputs selector"*: `Report`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> - {%icon param-select%} *"Outputs selector"*: `Report`
> - {%icon param-select%} *"Additional outputs to generate"*: `Report`

Also forgot to update that name in the first section with cutadapt so if you could please also change it there :-)

wm75
wm75 previously approved these changes Feb 11, 2025
Copy link
Member

@wm75 wm75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@VerenaMoo
Copy link
Contributor Author

Additionally I will update FastQE to version 0.31 including the corresponding pictures real quick. Could the pull request stay open for this?

Copy link
Member

@wm75 wm75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@wm75 wm75 merged commit ae9d750 into galaxyproject:main Feb 11, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants