Skip to content

New copernicusmarine version #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Mar 20, 2025
Merged

New copernicusmarine version #157

merged 19 commits into from
Mar 20, 2025

Conversation

Marie59
Copy link
Collaborator

@Marie59 Marie59 commented Mar 19, 2025

PR number 2

@bgruening
Copy link
Collaborator

Ok, now there are real linting errors:

 +Linting tool /home/runner/work/tools-ecology/tools-ecology/tools/ocean/argo_getdata.xml
Failed linting
.. WARNING (TestsCaseValidation): Test 1: failed to validate test parameters against inputs - tests won't run on a modern Galaxy tool profile version. Validation errors are [Invalid parameter name found data_selection]
.. WARNING (TestsCaseValidation): Test 2: failed to validate test parameters against inputs - tests won't run on a modern Galaxy tool profile version. Validation errors are [Invalid parameter name found data_selection]
.. WARNING (TestsCaseValidation): Test 3: failed to validate test parameters against inputs - tests won't run on a modern Galaxy tool profile version. Validation errors are [Invalid parameter name found data_selection]
.. WARNING (TestsCaseValidation): Test 4: failed to validate test parameters against inputs - tests won't run on a modern Galaxy tool profile version. Validation errors are [Invalid parameter name found data_selection]
.. WARNING (TestsCaseValidation): Test 5: failed to validate test parameters against inputs - tests won't run on a modern Galaxy tool profile version. Validation errors are [Invalid parameter name found data_selection]

bgruening
bgruening reviewed Mar 20, 2025
View reviewed changes
tools/ocean/copernicusmarine.xml Outdated
#set $filename="config_file_with_my_command"
echo -e '$input_text' > $filename --force-download --username $cmems_username --password $cmems_password &&
echo -e '$input_text' > config_file_with_my_command &&
echo ' --force-download ' >> config_file_with_my_command &&
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, this does not work, can you add this force-download as part of your check.py?

@bgruening bgruening closed this Mar 20, 2025
@bgruening bgruening reopened this Mar 20, 2025
@Marie59 Marie59 closed this Mar 20, 2025
@Marie59 Marie59 reopened this Mar 20, 2025
@bgruening bgruening merged commit ecc01d1 into galaxyecology:master Mar 20, 2025
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgruening bgruening bgruening left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Marie59 @bgruening