check for nil values before printing hpa current cpu utilization

gabrie30 · Apr 15, 2018 · 998bc1e · 998bc1e
1 parent 71ad73c
commit 998bc1e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/README.md b/README.md
@@ -11,3 +11,6 @@ Internal cluster monitoring
 - $ docker build -t kubieous:v1 .
 - $ kubectl run kubieous --image=kubieous:v1 --port=8080
 - You'll also want to run an image that you can test on
+
+## Testing HPA
+- You need to enable heapster `$ minikube addons enable heapster`
diff --git a/checks/hpa.go b/checks/hpa.go
@@ -44,10 +44,14 @@ func handleEventz(event watch.Event) {
 	if hpa.Status.CurrentReplicas > hpa.Status.DesiredReplicas {
 		fmt.Println(hpa.ObjectMeta.Namespace + " is scaling DOWN")
 		fmt.Println("Current VS Desired Replicas: ", hpa.Status.CurrentReplicas, hpa.Status.DesiredReplicas)
-		fmt.Println("Current CPU utilization: ", *hpa.Status.CurrentCPUUtilizationPercentage)
+		if hpa.Status.CurrentCPUUtilizationPercentage != nil {
+			fmt.Println("Current CPU utilization: ", *hpa.Status.CurrentCPUUtilizationPercentage)
+		}
 	} else if hpa.Status.CurrentReplicas < hpa.Status.DesiredReplicas {
-		fmt.Println(hpa.ObjectMeta.Namespace + " is scaling up")
+		fmt.Println(hpa.ObjectMeta.Namespace + " is scaling UP")
 		fmt.Println("Current VS Desired Replicas: ", hpa.Status.CurrentReplicas, hpa.Status.DesiredReplicas)
-		fmt.Println("Current CPU utilization: ", *hpa.Status.CurrentCPUUtilizationPercentage)
+		if hpa.Status.CurrentCPUUtilizationPercentage != nil {
+			fmt.Println("Current CPU utilization: ", *hpa.Status.CurrentCPUUtilizationPercentage)
+		}
 	}
 }