🐛 Get legend from wms layer through internal qgisserver if set intern…

…al (#714)

* 🐛 Get legend from wms layer through internal qgisserver if set internal

* 🐛 show loading legend image bar

* ✨ Set legend tab background color transparent or white based on transparent legend setting value

(cherry picked from commit dcce3b7)

src/components/Catalog.vue

@@ -227,6 +227,7 @@
           role   = "tabpanel"
           id     = "legend"
           class  = "tab-pane"
+          :style = "{ backgroundColor: backgroundLegend }"
           :class = "{ active: 'legend' === activeTab }"
         >
           <div v-for = "t in tree.tree" class = "legend-item"> <!-- TODO: check if such nesting level really necessary.. -->
@@ -320,6 +321,7 @@ export default {
       legend_position:  ApplicationState.project.state.legend_position || 'tab',
       iframe:           ApplicationState.iframe,
       showlegend:       false,
+      backgroundLegend: ApplicationState.gui.layout.app.legend.transparent ? 'transparent' : '#FFFFFF', //@since 3.11.3 set transparent or white background
       currentBaseLayer: null,
       activeTab:        'layers',
       loading:          false,
@@ -370,13 +372,13 @@ export default {
 
   methods: {
 
-    onLegendError(legendurl) {
-      legendurl.error   = true;
-      legendurl.loading = false;
+    onLegendError(url) {
+      url.error   = true;
+      url.loading = false;
     },
 
-    onLegendLoad(legendurl) {
-      legendurl.loading = false;
+    onLegendLoad(url) {
+      url.loading = false;
     },
 
     /**
@@ -522,8 +524,6 @@ export default {
           } catch (e) {
             console.warn(e);
           }
-
-          obj.loading = false;
         }
       }
       return legendurls;

src/map/layers/imagelayer.js

@@ -660,7 +660,7 @@ class ImageLayer extends GeoLayerMixin(Layer) {
     return (
         source && (
         ('map' !== type || (this.isExternalWMS() && this.isLayerProjectionASMapProjection())) &&
-        ('legend' === type || source.external)
+        ('legend' !== type || source.external)
       )
     );
   }