Update proposal based on feedback #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-demicev
approved these changes
Apr 7, 2025
| - Allow users to update Kubernetes clusters using pluggable External Update Extension. | ||
| - Maintain a coherent user experience for both rolling and in-place updates. | ||
| - Support External Update Extensions for both Control Plane (KCP or others) and MachineDeployment controlled machines. | ||
| - Allow in-place updates for single-node clusters without the requirement to reprovision hosts. | ||
|
|
||
| ### Non-Goals/Future work | ||
|
|
||
| - To provide rollbacks in case of an in-place update failure. Failed updates need to be fixed manually by the user on the machine or by replacing the machine. | ||
| - Introduce any changes to KCP (or any other control plane provider), MachineDeployment, MachineSet, Machine APIs. | ||
| - Ammend the desired state to something that the registered updaters can cover or register additional updaters capable of handling the desired changes. |
There was a problem hiding this comment.
There was a comment about this sentence being hard to understand, maybe we can remove it?
There was a problem hiding this comment.
Moved it to Non-Goals/Future work section as per suggestion. As per Danil's comment below, I'll indicate this is indeed a future goal. Let me know if you still think we should remove this though.
|
|
||
| Once all of the updaters are complete, the Machine controller will mark machine as done. If the update fails, this will be reflected in the Machine status. | ||
|
|
||
| From this point on, the `KCP` or `MachineDeployment` controller will take over and set the `UpToDate` condition to `True`. | ||
|
|
||
| Note: We might revisit which controller should set `UpToDate` during implementation, because we have to make sure there are no race conditions that can lead to reconcile failures, but apart from the ownership of this operation, the workflows described in this doc should not be impacted. |
Danil-Grigorev
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR updates the in-places updates proposal to include most (if not all) of the changes proposed against kubernetes-sigs#11029 as of now.