Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typos and add bilibili module #43

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix typos and add bilibili module #43

wants to merge 2 commits into from

Conversation

Qifull
Copy link
Contributor

@Qifull Qifull commented Jan 24, 2025

No description provided.

@fynks
Copy link
Owner

fynks commented Jan 25, 2025 •
edited
Loading

  • Thanks a lot for adding the module.
  • Regarding the the change of ##### ColorOS (Oppo) to ##### ColorOS (Oppo/OnePlus) , It breaks the Vitepress navigation in my tests can you please double check if it's the same case for you?

@Qifull
Copy link
Contributor Author

Qifull commented Jan 25, 2025

Can you send me a screenshot of Viatepress navigation, bc I don’t know what situation is.

@fynks
Copy link
Owner

fynks commented Jan 26, 2025

  • If you clone the repo and after running npm install in the project and then run pnpm run docs:dev you can replicate the dev environment on your machine and can verify this error.

  • For me, navigating to http://localhost:5173/apps#coloros-oppooneplus breaks the automatic scrolling to the colorOS segment, instead it stays at TOC:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Qifull @fynks